Merged
Conversation
0b44ff2 to
2859ff0
Compare
These files are not needed anymore, use the project global once instead. Signed-off-by: Daniel Wagner <[email protected]>
The code base is mostly in 80 character line length written. Let's keep it there as it looks odd the different styles and nothing really is gained by the 100 chars. If you can't write it properly in 80 then 100 will not be enough anyway. Signed-off-by: Daniel Wagner <[email protected]>
bce3ffa to
74bd831
Compare
Move the existing libnvme github workflows to the top dir and update them accordingly. It is not clear how the release is suppose to work but let's leave this for later. Signed-off-by: Daniel Wagner <[email protected]>
74bd831 to
7b923f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the integration for libnvme enable back the specific libnvme CI builds.